graph primitive transform_e #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunghwak
added
feature request
jnke2016
approved these changes
May 9, 2023
naimnv
requested changes
May 9, 2023
Comment on lines
+103
to
+120
| if (majors_.size() > 0) { | ||
| rmm::device_scalar<vertex_t> tmp_src(src, handle_ptr_->get_stream()); | ||
| rmm::device_scalar<vertex_t> tmp_dst(dst, handle_ptr_->get_stream()); | ||
| auto pair_first = | ||
| thrust::make_zip_iterator(thrust::make_tuple(tmp_src.data(), tmp_dst.data())); | ||
| insert(tmp_src.data(), tmp_src.data() + 1, tmp_dst.data()); | ||
| } else { | ||
| auto major = src_major ? src : dst; | ||
| auto minor = src_major ? dst : src; | ||
| majors_.resize(1, handle_ptr_->get_stream()); | ||
| minors_.resize(1, handle_ptr_->get_stream()); | ||
| auto pair_first = | ||
| thrust::make_zip_iterator(thrust::make_tuple(majors_.data(), minors_.data())); | ||
| thrust::fill(handle_ptr_->get_thrust_policy(), | ||
| pair_first, | ||
| pair_first + 1, | ||
| thrust::make_tuple(major, minor)); | ||
| } |
There was a problem hiding this comment.
Couldn't the checks for size and resizing be avoided here as they are done in
void insert(VertexIterator src_first, VertexIterator src_last, VertexIterator dst_first) anyway?
There was a problem hiding this comment.
This is to avoid creating temporary buffers (tmp_src and tmp_dst).
Comment on lines
+133
to
+145
| if (majors_.size() > 0) { | ||
| rmm::device_scalar<vertex_t> tmp_src(src, handle_ptr_->get_stream()); | ||
| rmm::device_scalar<vertex_t> tmp_dst(dst, handle_ptr_->get_stream()); | ||
| rmm::device_scalar<tag_t> tmp_tag(tag, handle_ptr_->get_stream()); | ||
| auto triplet_first = thrust::make_zip_iterator( | ||
| thrust::make_tuple(tmp_src.data(), tmp_dst.data(), tmp_tag.data())); | ||
| insert(tmp_src.data(), tmp_src.data() + 1, tmp_dst.data(), tmp_tag.data()); | ||
| } else { | ||
| auto major = src_major ? src : dst; | ||
| auto minor = src_major ? dst : src; | ||
| majors_.resize(1, handle_ptr_->get_stream()); | ||
| minors_.resize(1, handle_ptr_->get_stream()); | ||
| tags_.resize(1, handle_ptr_->get_stream()); |
There was a problem hiding this comment.
Same here, checks for size and resizing is done inside
void insert(VertexIterator src_first, VertexIterator src_last, VertexIterator dst_first, TagIterator tag_first) as well
There was a problem hiding this comment.
Same here, we don't need to create temporary buffers in the else case.
naimnv
reviewed
May 9, 2023
Comment on lines
+327
to
+334
| for (auto it = lower_it; it != upper_it; ++it) { | ||
| assert(*it == minor); | ||
| auto e_op_result = | ||
| e_op(src, | ||
| dst, | ||
| edge_partition_src_value_input.get(src_offset), | ||
| edge_partition_dst_value_input.get(dst_offset), | ||
| edge_partition_e_value_input.get(edge_offset + thrust::distance(indices, it))); |
There was a problem hiding this comment.
General question:
It would results in a multiple iteration only if there are multiple edges between (major, minor)?
naimnv
approved these changes
May 9, 2023
ChuckHastings
approved these changes
May 10, 2023
cpp/tests/prims/mg_transform_e.cu
Outdated
| @@ -0,0 +1,367 @@ | |||
| /* | |||
| * Copyright (c) 2021-2023, NVIDIA CORPORATION. | |||
cpp/src/prims/transform_e.cuh
Outdated
| @@ -0,0 +1,342 @@ | |||
| /* | |||
| * Copyright (c) 2020-2023, NVIDIA CORPORATION. | |||
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new primitive to update edge property values (for a given set of edges, haven't implemented a case for all edges). This is necessary to implement K-truss.