-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Match the PyG API for Node Input to the Loader #3514
Merged
rapids-bot
merged 15 commits into
rapidsai:branch-23.06
from
alexbarghi-nv:fix-dict-api-pyg
May 18, 2023
Merged
[FIX] Match the PyG API for Node Input to the Loader #3514
rapids-bot
merged 15 commits into
rapidsai:branch-23.06
from
alexbarghi-nv:fix-dict-api-pyg
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarghi-nv
added
bug
Something isn't working
non-breaking
Non-breaking change
labels
Apr 25, 2023
rlratzel
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment about a debug print which need not hold up approval.
alexbarghi-nv
added
bug
Something isn't working
non-breaking
Non-breaking change
and removed
bug
Something isn't working
non-breaking
Non-breaking change
labels
May 10, 2023
rlratzel
approved these changes
May 11, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures heterogeneous graphs can be handled correctly in cugraph-pyg. Also cleans up some technical debt and adds some key tests.
Resolves #3333