Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Match the PyG API for Node Input to the Loader #3514

Merged
merged 15 commits into from
May 18, 2023

Conversation

alexbarghi-nv
Copy link
Member

Ensures heterogeneous graphs can be handled correctly in cugraph-pyg. Also cleans up some technical debt and adds some key tests.
Resolves #3333

@alexbarghi-nv alexbarghi-nv added bug Something isn't working non-breaking Non-breaking change labels Apr 25, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.06 milestone Apr 25, 2023
@alexbarghi-nv alexbarghi-nv self-assigned this Apr 25, 2023
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review April 25, 2023 20:44
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner April 25, 2023 20:44
@alexbarghi-nv alexbarghi-nv marked this pull request as draft April 26, 2023 18:21
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review April 26, 2023 19:01
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment about a debug print which need not hold up approval.

@alexbarghi-nv alexbarghi-nv marked this pull request as draft May 10, 2023 14:40
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review May 10, 2023 14:40
@alexbarghi-nv alexbarghi-nv added bug Something isn't working non-breaking Non-breaking change and removed bug Something isn't working non-breaking Non-breaking change labels May 10, 2023
@alexbarghi-nv alexbarghi-nv requested a review from a team May 10, 2023 14:42
@alexbarghi-nv
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 4ea838f into rapidsai:branch-23.06 May 18, 2023
@alexbarghi-nv alexbarghi-nv deleted the fix-dict-api-pyg branch May 18, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] Properly Support and Require a Dictionary for cugraph-PyG Sampling
3 participants