Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs #3510

Merged
merged 10 commits into from
Apr 28, 2023
Merged

update docs #3510

merged 10 commits into from
Apr 28, 2023

Conversation

BradReesWork
Copy link
Member

@BradReesWork BradReesWork commented Apr 24, 2023 •
edited
Loading

Addressing a number of doc issues

closes #2500
closes #3141
closes #3213

@BradReesWork BradReesWork requested review from a team as code owners April 24, 2023 19:29
@BradReesWork BradReesWork marked this pull request as draft April 24, 2023 19:29
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 24, 2023
@BradReesWork BradReesWork self-assigned this Apr 24, 2023
@BradReesWork BradReesWork marked this pull request as ready for review April 25, 2023 19:13
acostadon
acostadon approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I remember Chuck saying Hungarian is going away. If so maybe that should be noted?
Other than that looks good to me.

@ChuckHastings
Copy link
Collaborator

I thought I remember Chuck saying Hungarian is going away. If so maybe that should be noted?
Other than that looks good to me.

We haven't scheduled the work to do that yet. When we do that migration we should probably add a note to the documentation here (and a deprecation warning in the code) for a release before deleting. So I think the documentation should include this until we schedule that work.

rlratzel
rlratzel reviewed Apr 27, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just had a couple of suggestions. I can approve if you don't think they should be used.

docs/cugraph/source/graph_support/wholegraph_support.md Outdated Show resolved Hide resolved
docs/cugraph/source/index.rst Outdated Show resolved Hide resolved
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit dca4d4c into rapidsai:branch-23.06 Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostadon acostadon acostadon approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees

@BradReesWork BradReesWork

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
4 participants
@BradReesWork @ChuckHastings @rlratzel @acostadon