Updates to allow python benchmarks to run on additional datasets by default #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have weight columns, and to auto convert to undirected for algos that require that.
… fixed set of RMM options by default instead of all combinations.
…6-benchmark_bugfix
ajschmidt8
approved these changes
Apr 24, 2023
2 tasks
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3321
closes #3331
This PR includes updates to allow benchmarks to run on additional datasets that don't have weight columns, and to auto convert to undirected for algos that require that.
These datasets are not normally run in CI (when CI runs them as tests), since CI uses the
-m tinymarker to get coverage using a few small datasets in order to keep CI runs quick.This also removes the
--no-rmm-reinitpytest option and replaces it with--allow-rmm-reinitin order to create a default set of RMM options to run with, instead of all combinations by default. A fixed set of options is (according to my understanding) the typical use case, and changing them multiple times within the same process is atypical and not supported well. Testers now have to pass--allow-rmm-reinitto have pytest run with multiple RMM config options.