cugraph: Build CUDA 12 packages #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
feature request
vyasr
changed the title
raydouglass
pushed a commit
that referenced
this pull request
Jul 18, 2023
We are planning to enable CUDA 12 CI jobs on July 18, per rapidsai/shared-workflows#112. This PR must be merged to disable CUDA 12 CI jobs for cugraph until #3271 / #3456 are merged. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass)
…f temporary cuda-120 branches to workflow files now that they've been merged to branch-23.08.
bdice
reviewed
Jul 19, 2023
…eded static and dev dependencies, removes unneeded cuda_spec pins, adds missing use of cuda-version meta-package.
bdice
reviewed
Jul 19, 2023
bdice
reviewed
Jul 19, 2023
…onda dev env generation.
raydouglass
approved these changes
Jul 19, 2023
|
Seeing errors like this on CI. This is happening on all Python jobs. Did something else change? # cython layer but users are encourage to switch to device_resources
cdef extern from "raft/core/handle.hpp" namespace "raft" nogil:
cdef cppclass handle_t:
handle_t() except +
handle_t(cuda_stream_view stream_view) except +
^
------------------------------------------------------------
$PREFIX/lib/python3.9/site-packages/pylibraft/common/handle.pxd:34:17: 'cuda_stream_view' is not a type identifierEdit: Bradley determine this was an upstream issue in RAFT and submitted PR ( rapidsai/raft#1656 ) to address |
jakirkham
reviewed
Jul 19, 2023
conda/recipes/pylibcugraph/meta.yaml
Outdated
Comment on lines
61
to
62
| # TODO: Remove rmm once https://github.com/rapidsai/raft/pull/1656 is merged (fixes pylibraft use of rmm) | ||
| - rmm ={{ minor_version }} |
There was a problem hiding this comment.
Are there any linkages to RMM from pylibcugraph itself? Does it use rmm's Cython interface?
bdice
reviewed
Jul 19, 2023
conda/recipes/pylibcugraph/meta.yaml
Outdated
| - python | ||
| # TODO: Remove rmm once https://github.com/rapidsai/raft/pull/1656 is merged (fixes pylibraft use of rmm) |
There was a problem hiding this comment.
@jakirkham FYI, this is the line where this rmm dependency existed before. This TODO just makes it clear that it's a workaround with an upstream fix in progress. I'd be fine merging this PR with this dependency still in place since it affects both CUDA 11 and CUDA 12.
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Jul 19, 2023
…1656) There is a build error in rapidsai/cugraph#3456: ``` $PREFIX/lib/python3.9/site-packages/pylibraft/common/handle.pxd:47:8: 'cuda_stream_view' is not a type identifier ``` pylibraft should have a `run` dependency on `rmm` so that Cython users of pylibraft (pylibcugraph in this case) can `cimport` and use pylibraft Cython at build time. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - AJ Schmidt (https://github.com/ajschmidt8) - https://github.com/jakirkham URL: #1656
ChuckHastings
approved these changes
Jul 19, 2023
bdice
approved these changes
Jul 20, 2023
rlratzel
approved these changes
Jul 20, 2023
jakirkham
approved these changes
Jul 20, 2023
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
This PR adds the CUDA 12.0 conda environment, which was missed in #3456. It is automatically generated by `rapids-dependency-file-generator` from `dependencies.yaml` but was not committed to the repo. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #3725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at building libcugraph with CUDA 12 and nvidia channel packages
Closes #3271