Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dfg as a pre-commit hook. #3294

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Add dfg as a pre-commit hook. #3294

merged 3 commits into from
Feb 24, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 22, 2023

This change allows local and remote runs to handle calls to dfg identically, and removes the need for a separate CI check.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 22, 2023
@vyasr vyasr requested a review from a team as a code owner February 22, 2023 00:27
@vyasr vyasr self-assigned this Feb 22, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Feb 22, 2023

Converting to draft pending some discussions on rapidsai/shared-workflows#46.

@vyasr vyasr marked this pull request as draft February 22, 2023 18:54
vyasr
vyasr commented Feb 24, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
@vyasr vyasr marked this pull request as ready for review February 24, 2023 18:15
@vyasr
Copy link
Contributor Author

vyasr commented Feb 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit f57847e into rapidsai:branch-23.04 Feb 24, 2023
@vyasr vyasr deleted the feat/dfg_pre_commit branch February 24, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @ajschmidt8