-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a notebook comparing nx and cuGraph using synthetic data #3135
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
minor text changed needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some text needs to be updated and the generator fixed
From a content perspective, this notebook works well for the website benchmark. For viz: rapidsai/cuml#5103 (comment) |
Codecov ReportBase: 55.22% // Head: 55.22% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3135 +/- ##
=============================================
Coverage 55.22% 55.22%
=============================================
Files 148 148
Lines 9543 9543
=============================================
Hits 5270 5270
Misses 4273 4273 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The notebook need a header block at the top explain what it is doing |
Cell 3: The names of the datasets are confusing. What not "data_scale_11" instead of "data_11th" . I'm not sure what the "11th" is |
Cel 4 - the text is wrong - this is not a data reader |
cell 4: |
Cell 5 - why not combine the two cuGraph creates into one and have a "direction" flag passed in? It used to be two functions since there was Graph and DiGraph, but that is no longer the case |
Cell 6 - Katz still have the Nx object function |
Cell 12: PageRank
why not just create an undirected graph? |
Cell 3: Do Scales: (or pick 3 or 4) NOTE: using the large datasets will be very very slow in Nx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
/merge |
Rapids visualization group asked for some data comparing cuGraph algos to nx.
Used Release notebook as a base, replaced datasets with RMAT data generator.
Closes #3134