Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added build.sh script, updated CI scripts and documentation #301

Merged
merged 6 commits into from
May 28, 2019

Conversation

rlratzel
Copy link
Contributor

This PR adds a new top-level script named build.sh that allows a contributor to build from source using the same commands and options the CI system, container builds, doc builds, nightly unit test runs, and (eventually) ASV build & test iterations use. The relevant CI scripts have been updated to call this script and all related documentation should be updated as well.

This PR allows a maintainer to update the common build steps in one place while also simplifying the build process for all contributors and other build-related operations.

The changes were tested using the gpuCI container via the ci/local/build.sh testing script, where cugraph branch-0.8 was successfully built and tested without errors.

@rlratzel rlratzel requested review from afender and BradReesWork May 24, 2019 20:42
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That's very helpful.
A few questions/comments inline in the code.

build.sh Outdated Show resolved Hide resolved
build.sh Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
build.sh Show resolved Hide resolved
…etup.py install options, updated docs accordingly.
@BradReesWork BradReesWork merged commit 14144ee into rapidsai:branch-0.8 May 28, 2019
@rlratzel rlratzel deleted the branch-0.8-buildscript branch April 8, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants