Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle the vertex pair #3002

Merged

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Nov 30, 2022

An illegal memory access occurs when running the MG similarity algos at certain scale. This is caused by vertex pairs not being shuffled appropriately.
This PR:

  1. Shuffle the vertex pairs based on the edge partitioning
  2. Update the the vertex pairs column names which are not necessarily edgelists
  3. Update the docstrings, tests and notebooks accordingly

closes #3001

@jnke2016 jnke2016 requested review from a team as code owners November 30, 2022 02:50
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 30, 2022
@BradReesWork BradReesWork added this to the 22.12 milestone Nov 30, 2022
@jnke2016
Copy link
Contributor Author

rerun tests

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor documentation typo.

" df[\"destination\"]: The destination vertex id.\n",
" df[\"jaccard_coeff\"]: The jaccard coefficient computed between the source and destination vertex.\n",
" df[\"first\"]: The first vertex id of each pair.\n",
" df[\"second\"]: The second vertex i of each pair.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "i" should be "id"

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8148123 into rapidsai:branch-22.12 Nov 30, 2022
rapids-bot bot pushed a commit that referenced this pull request Aug 25, 2023
A [PR](#3002) updating the vertex pair column names was merged few releases ago however few docstrings weren't.
This PR updates the docstrings for Jaccard and Sorensen.

Authors:
  - Joseph Nke (https://github.com/jnke2016)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)

URL: #3817
rlratzel pushed a commit to rlratzel/cugraph that referenced this pull request Sep 8, 2023
A [PR](rapidsai#3002) updating the vertex pair column names was merged few releases ago however few docstrings weren't.
This PR updates the docstrings for Jaccard and Sorensen.

Authors:
  - Joseph Nke (https://github.com/jnke2016)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)

URL: rapidsai#3817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: vertex pair not properly shuffled
4 participants