-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shuffle the vertex pair #3002
Shuffle the vertex pair #3002
Conversation
… user deletes the original but needs to recreate
…into fea_k_core_api
…docstrings accordingly
…docstrings accordingly
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor documentation typo.
" df[\"destination\"]: The destination vertex id.\n", | ||
" df[\"jaccard_coeff\"]: The jaccard coefficient computed between the source and destination vertex.\n", | ||
" df[\"first\"]: The first vertex id of each pair.\n", | ||
" df[\"second\"]: The second vertex i of each pair.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "i" should be "id"
@gpucibot merge |
A [PR](#3002) updating the vertex pair column names was merged few releases ago however few docstrings weren't. This PR updates the docstrings for Jaccard and Sorensen. Authors: - Joseph Nke (https://github.com/jnke2016) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) URL: #3817
A [PR](rapidsai#3002) updating the vertex pair column names was merged few releases ago however few docstrings weren't. This PR updates the docstrings for Jaccard and Sorensen. Authors: - Joseph Nke (https://github.com/jnke2016) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) URL: rapidsai#3817
An illegal memory access occurs when running the MG similarity algos at certain scale. This is caused by vertex pairs not being shuffled appropriately.
This PR:
closes #3001