Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package to the list of dependencies #2858

Merged

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Oct 27, 2022

A breaking pytest change removed the py package from its list of dependencies causing the SG/MG tests to fail.
This PR adds the package to our list of dependencies.
In addition to the above, this PR also:

  1. Reduces the value of the fanout_vals when testing uniform_neighbor_sampling
  2. Updates the ownership transfer of device_buffer_unique_ptr to cuDF buffer through the call as_buffer()

closes #2857
closes #2881

@jnke2016 jnke2016 requested a review from a team as a code owner October 27, 2022 20:39
@jnke2016 jnke2016 requested a review from a team as a code owner October 28, 2022 20:22
@ChuckHastings ChuckHastings added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Oct 28, 2022
@jnke2016
Copy link
Contributor Author

rerun tests

@msadang
Copy link
Contributor

msadang commented Oct 31, 2022

rerun tests

@ChuckHastings
Copy link
Collaborator

rerun tests

Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py and range changes look good.

@BradReesWork
Copy link
Member

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@1a1d52f). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head e93f5ba differs from pull request most recent head 1057666. Consider uploading reports for the commit 1057666 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #2858   +/-   ##
===============================================
  Coverage                ?   46.64%           
===============================================
  Files                   ?      114           
  Lines                   ?     6395           
  Branches                ?        0           
===============================================
  Hits                    ?     2983           
  Misses                  ?     3412           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8ffbbcb into rapidsai:branch-22.12 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
6 participants