Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K-hop neighbors #2782

Merged
merged 12 commits into from
Oct 13, 2022
Merged

K-hop neighbors #2782

merged 12 commits into from
Oct 13, 2022

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Oct 6, 2022 •
edited
Loading

K-hop neighbors implementation (mainly to support 2-hop neighbors).

@seunghwak seunghwak requested a review from a team as a code owner October 6, 2022 18:52
@seunghwak seunghwak added feature request New feature or request 2 - In Progress non-breaking Non-breaking change labels Oct 6, 2022
@seunghwak seunghwak requested a review from a team as a code owner October 7, 2022 21:12
@BradReesWork BradReesWork added this to the 22.12 milestone Oct 10, 2022
@seunghwak seunghwak self-assigned this Oct 10, 2022
@seunghwak seunghwak changed the title [WIP][skip-ci] K-hop neighbors K-hop neighbors Oct 10, 2022
@seunghwak
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@4d020cb). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 7a13d6f differs from pull request most recent head cfb29b0. Consider uploading reports for the commit cfb29b0 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.12    #2782   +/-   ##
===============================================
  Coverage                ?   59.72%           
===============================================
  Files                   ?      111           
  Lines                   ?     6448           
  Branches                ?        0           
===============================================
  Hits                    ?     3851           
  Misses                  ?     2597           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ChuckHastings
ChuckHastings approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One little copyright observation.

cpp/tests/traversal/k_hop_nbrs_test.cpp
@@ -0,0 +1,298 @@
/*
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just 2022

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 563c97c into rapidsai:branch-22.12 Oct 13, 2022
@seunghwak seunghwak deleted the fea_k_hop_nbrs branch October 20, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naimnv naimnv naimnv approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@jnke2016 jnke2016 Awaiting requested review from jnke2016

Assignees

@seunghwak seunghwak

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
22.12
Development

Successfully merging this pull request may close these issues.
5 participants
@seunghwak @codecov-commenter @ChuckHastings @naimnv @BradReesWork