-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a random selection primitive #2703
Implement a random selection primitive #2703
Conversation
rerun tests |
Codecov ReportBase: 60.04% // Head: 60.04% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #2703 +/- ##
=============================================
Coverage 60.04% 60.04%
=============================================
Files 111 111
Lines 6184 6184
=============================================
Hits 3713 3713
Misses 2471 2471 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed over the changes. This PR contains a good set of changes to understand how prims should be written :) Will go though the files at later point to understand them better.
@gpucibot merge |
Closes #2581 Closes #2582 Closes #2665 Update the neighborhood sampling algorithm to use the new neighborhood sampling primitive defined in #2703 Authors: - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Seunghwa Kang (https://github.com/seunghwak) URL: #2751
Add a primitive to support randomly selecting (without biases) vertex neighbors.
Also, refactored primitive tests to avoid duplicating code for vertex/edge source/edge destination property value generation.