Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip-ci] new notebook for loading mag240m #2701

Merged
merged 4 commits into from
Sep 30, 2022
Merged

[skip-ci] new notebook for loading mag240m #2701

merged 4 commits into from
Sep 30, 2022

Conversation

BradReesWork
Copy link
Member

@BradReesWork BradReesWork commented Sep 14, 2022 •
edited
Loading

closes #2674

@BradReesWork BradReesWork requested a review from a team as a code owner September 14, 2022 16:15
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 14, 2022
@BradReesWork BradReesWork added this to the 22.10 milestone Sep 14, 2022
rlratzel
rlratzel reviewed Sep 20, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions.

Note the "can you comment ..." feedback is meant for updating comments in the notebook, not commenting in the PR review here.

notebooks/gnn/mag240m_pg.ipynb Outdated Show resolved Hide resolved
notebooks/gnn/mag240m_pg.ipynb Outdated Show resolved Hide resolved
notebooks/gnn/mag240m_pg.ipynb Outdated Show resolved Hide resolved
notebooks/gnn/mag240m_pg.ipynb Outdated Show resolved Hide resolved
@rlratzel
Copy link
Contributor

rerun tests

reason: mamba download error

@BradReesWork
Copy link
Member Author

rerun tests

@BradReesWork BradReesWork changed the title new notebook for loading mag240m new notebook for loading mag240m [skip-ci] Sep 26, 2022
@BradReesWork
Copy link
Member Author

rerun tests

2 similar comments
@BradReesWork
Copy link
Member Author

rerun tests

@BradReesWork
Copy link
Member Author

rerun tests

@BradReesWork BradReesWork changed the title new notebook for loading mag240m [skip-ci] [skip-ci] new notebook for loading mag240m Sep 28, 2022
@BradReesWork
Copy link
Member Author

rerun tests

1 similar comment
@raydouglass
Copy link
Member

rerun tests

@rlratzel
Copy link
Contributor

rerun tests

reason: Ops may have disabled the suspected problematic node that had problems accessing the repo by now, trying again

@BradReesWork
Copy link
Member Author

rerun tests

@raydouglass
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5a2cf3e into rapidsai:branch-22.10 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.10
Development

Successfully merging this pull request may close these issues.

[FEA] Create a notebook that loads MAG240M into a Property Graph
3 participants
@BradReesWork @rlratzel @raydouglass