-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a C API for data masking #2630
Define a C API for data masking #2630
Conversation
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChuckHastings I wonder, how the association between a graph and mask would be kept?
If the caller explicitly maintains that association then it's understood.
Apart from that, the API looks very transparent to me.
My intention was to support the C API's graph object to maintain that connection. Sequence of operations would be:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #2630 +/- ##
===============================================
Coverage ? 60.44%
===============================================
Files ? 111
Lines ? 6515
Branches ? 0
===============================================
Hits ? 3938
Misses ? 2577
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@gpucibot merge |
Add a C API for data masking.
Closes #2571
The objective here is to add a C API that will allow us to associated a data mask with a graph. Basic functions:
Current plan is to allow for the creation of a mask by the caller (the python layer for our current use case) and have it passed in. We may later add support for other techniques.
This PR can be approved independently, but implementation of the API is dependent on #2679