-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MG PLC algos intermittent hang #2607
Merged
rapids-bot
merged 12 commits into
rapidsai:branch-22.10
from
jnke2016:branch-22.10_fix-mg-plc-algos-hang
Aug 31, 2022
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9918ec9
manually delete inactive futures
df66277
fix style
d6b7f39
trigger computation in distributed memory, ensure job stealing doesn'…
4ae6650
fix typo
00aa165
delete the inactive cudf_result
a5150a6
fix typo
jnke2016 9a3c45a
ping setuptools version for cugraph
jnke2016 b0d58fb
unpin setuptools version for cugraph
jnke2016 e14f94a
remove flag
jnke2016 b43cbd1
pin setuptools version for cugraph
jnke2016 0096afe
pin different setuptools version for cugraph
jnke2016 e322a86
add FIXME
jnke2016 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -114,6 +114,7 @@ def core_number(input_graph, | |
degree_type, | ||
do_expensive_check, | ||
workers=[w], | ||
allow_other_workers=False, | ||
) | ||
for w in Comms.get_workers() | ||
] | ||
|
@@ -126,7 +127,17 @@ def core_number(input_graph, | |
|
||
wait(cudf_result) | ||
|
||
ddf = dask_cudf.from_delayed(cudf_result) | ||
ddf = dask_cudf.from_delayed(cudf_result).persist() | ||
wait(ddf) | ||
|
||
# FIXME: Dask doesn't always release it fast enough. | ||
# For instance if the algo is run several times with | ||
# the same PLC graph, the current iteration might try to cache | ||
# the past iteration's futures and this can cause a hang if some | ||
# of those futures get released midway | ||
del result | ||
del cudf_result | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest we also del |
||
if input_graph.renumbered: | ||
ddf = input_graph.unrenumber(ddf, "vertex") | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think removing
result
is still a good practice as whencudf_result
is completed we will still haveresult
in memory so from a memory relief standpoint it makes sense.