Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets API Update: Add Extra Params and Improve Testing #2453

Merged
merged 8 commits into from
Aug 1, 2022

Conversation

oorliu
Copy link
Contributor

@oorliu oorliu commented Jul 27, 2022

Adding two new parameters to the get_graph() method within the datasets API.

  • default_direction allows users to get only undirected graph objects.
  • weights will specify whether or not the cugraph.Graph object has an edge_attr field.

test_dataset.py has been updated to:

  1. Add coverage for the new parameters
  2. Removing fetching datasets from the web when it's unnecessary.

Docstrings have also been updated for clarity.

@oorliu oorliu requested a review from a team as a code owner July 27, 2022 18:06
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@93e15c0). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head efbbae9 differs from pull request most recent head 8cf6047. Consider uploading reports for the commit 8cf6047 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08    #2453   +/-   ##
===============================================
  Coverage                ?   61.21%           
===============================================
  Files                   ?      106           
  Lines                   ?     5553           
  Branches                ?        0           
===============================================
  Hits                    ?     3399           
  Misses                  ?     2154           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e15c0...8cf6047. Read the comment docs.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 28, 2022
@rlratzel rlratzel added this to the 22.08 milestone Jul 28, 2022
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple very minor changes, otherwise looks almost done.

python/cugraph/cugraph/experimental/datasets/dataset.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/experimental/datasets/dataset.py Outdated Show resolved Hide resolved
@rlratzel
Copy link
Contributor

rlratzel commented Aug 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2a57740 into rapidsai:branch-22.08 Aug 1, 2022
@oorliu oorliu deleted the update-params branch August 2, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants