-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cuco a private dependency and leverage rapids-cmake #2432
Conversation
It looks like there are a handful of tests and test utilities that make use of cugraph detail APIs that use cuco. Is that expected? This looks like dependency leakage due to use of |
…cessing libcugraph internals.
4e08e7b
to
f08929b
Compare
From some offline discussions, we've decided that the current tests are useful in their current form. While they may be rewritten at a later date after some significant internal refactorings, for now we're just going to link them directly to cuco to enable the continued used of the detail APIs. |
I was surprised to find how many of the multi-GPU tests have a cuco dependency, but I think I've got them all now. |
@gpucibot merge |
After #2398 cuco is not actually part of libcugraph's public API and should not be required by consumers. Since it is already not being installed, this PR removes it from the public link interface of libcugraph. This PR also uses rapids-cmake to fetch cuco, ensuring that libcugraph remains in sync with the rest of RAPIDS.
There are a handful of tests that still rely on
libcugraph::detail
APIs that use cuco. To minimize the leakage of these dependencies, they are explicitly linked to cuco (rather than the current approach where they receive the cuco headers transitively from the libcugraph target).