Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building without cugraph-ops #2405

Merged

Conversation

ChuckHastings
Copy link
Collaborator

Add -DUSE_CUGRAPH_OPS=OFF option for building where you can't access cugraph-ops. By default USE_CUGRAPH_OPS is set to ON.

If USE_CUGRAPH_OPS is set to OFF then the software will build without those features. At runtime functions that rely on cugraph-ops (currently this is only uniform neighborhood sampling) will fail with an exception.

@ChuckHastings ChuckHastings requested review from a team as code owners July 12, 2022 21:30
@ChuckHastings ChuckHastings self-assigned this Jul 12, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 12, 2022
@ChuckHastings ChuckHastings added this to the 22.08 milestone Jul 12, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@7a660e6). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0e7f3b2 differs from pull request most recent head 35c1db3. Consider uploading reports for the commit 35c1db3 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08    #2405   +/-   ##
===============================================
  Coverage                ?   60.11%           
===============================================
  Files                   ?      102           
  Lines                   ?     5155           
  Branches                ?        0           
===============================================
  Hits                    ?     3099           
  Misses                  ?     2056           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a660e6...35c1db3. Read the comment docs.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2aad5f2 into rapidsai:branch-22.08 Jul 13, 2022
@ChuckHastings ChuckHastings deleted the skip_cugraph_ops_for_power branch August 4, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants