Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some legacy BFS cleanup #2347

Merged

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Jun 7, 2022

Legacy BFS is still used by Betweenness Centrality. However, it's no longer called from python.

Remove the call_bfs functions from cython.cu, and remove a few legacy SSSP files that were missed by an earlier PR.

Also removed call_hits, which is not currently used either.

@ChuckHastings ChuckHastings requested a review from a team as a code owner June 7, 2022 18:57
@ChuckHastings ChuckHastings self-assigned this Jun 7, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 7, 2022
@BradReesWork BradReesWork added this to the 22.08 milestone Jun 8, 2022
@ChuckHastings
Copy link
Collaborator Author

rerun tests

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 808ffa6 into rapidsai:branch-22.08 Jun 21, 2022
@ChuckHastings ChuckHastings deleted the remove_bfs_from_cython_cu branch August 4, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants