Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Bug ext create column #232

Merged
merged 18 commits into from
Apr 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
97b9216
revmoed trailing spaces
seunghwak Apr 16, 2019
e06c743
replaced heap allocation of temporary C++ gdf_column objects with sta…
seunghwak Apr 16, 2019
ff98880
replaced create_column (heap-allocation for gdf_column) wiht get_gdf_…
seunghwak Apr 16, 2019
b088414
ReadMtxFile is renamed to read_mtx_file, but the comments were still …
seunghwak Apr 16, 2019
971c1bd
updated indentation inside cython typecasting operator to match cudf …
seunghwak Apr 16, 2019
d5f37e6
updated comments on get_gdf_column_view
seunghwak Apr 18, 2019
5b37c84
fixed a bug (not properly freeing valid) in gdf_col_delete
seunghwak Apr 18, 2019
e80277e
commented out freeing gdf_column's col_name if not nullptr, currently…
seunghwak Apr 19, 2019
57daf68
removed tab space in algorithms.h
seunghwak Apr 19, 2019
dea90dc
fixed a warning in louvain_wrapper.pyx (dereferencing type-punned poi…
seunghwak Apr 19, 2019
71a6bf7
replaced adjList.offsets.size - 1 and transposedAdjList.offsets.size …
seunghwak Apr 19, 2019
839bb3c
there were two implementations of num_vertices in class Graph, remove…
seunghwak Apr 19, 2019
85adcd8
there were two implementations of delete_adj_list in class Graph, rem…
seunghwak Apr 19, 2019
ee30f6f
changed variable names in view_adj_list and view_transposed_adj_list …
seunghwak Apr 19, 2019
2b96d97
removed unnecessary imports
seunghwak Apr 19, 2019
ee1f025
updated change log.
seunghwak Apr 19, 2019
ab837dd
fixed typo in variable name
seunghwak Apr 19, 2019
65a6310
fixed a typo
seunghwak Apr 22, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
- PR #218 Update c_graph.pyx
- PR #224 Update erroneous comments in overlap_wrapper.pyx, woverlap_wrapper.pyx, test_louvain.py, and spectral_clustering.pyx
- PR #220 Fixed bugs in Nvgraph triangle counting
- PR #232 Fixed memory leaks in managing cudf columns.

# cuGraph 0.6.0 (22 Mar 2019)

Expand Down
46 changes: 23 additions & 23 deletions cpp/include/algorithms.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@
*/
/* ----------------------------------------------------------------------------*/
gdf_error gdf_pagerank(gdf_graph *graph,
gdf_column *pagerank,
float alpha,
float tolerance,
int max_iter,
bool has_guess);
gdf_column *pagerank,
float alpha,
float tolerance,
int max_iter,
bool has_guess);

/**
* @Synopsis Creates source, destination and value columns based on the specified R-MAT model
Expand Down Expand Up @@ -78,11 +78,11 @@ gdf_error gdf_pagerank(gdf_graph *graph,
*/
/* ----------------------------------------------------------------------------*/
gdf_error gdf_grmat_gen(const char* argv,
size_t &vertices,
size_t &edges,
gdf_column* src,
gdf_column* dest,
gdf_column* val);
size_t &vertices,
size_t &edges,
gdf_column* src,
gdf_column* dest,
gdf_column* val);

/**
* @Synopsis Performs a breadth first search traversal of a graph starting from a node.
Expand All @@ -101,10 +101,10 @@ gdf_error gdf_grmat_gen(const char* argv,
*/
/* ----------------------------------------------------------------------------*/
gdf_error gdf_bfs(gdf_graph *graph,
gdf_column *distances,
gdf_column *predecessors,
int start_node,
bool directed);
gdf_column *distances,
gdf_column *predecessors,
int start_node,
bool directed);

/**
* Computes the Jaccard similarity coefficient for every pair of vertices in the graph
Expand All @@ -116,8 +116,8 @@ gdf_error gdf_bfs(gdf_graph *graph,
* @return Error code
*/
gdf_error gdf_jaccard(gdf_graph *graph,
gdf_column *weights,
gdf_column *result);
gdf_column *weights,
gdf_column *result);

/**
* Computes the Jaccard similarity coefficient for each pair of specified vertices.
Expand All @@ -131,10 +131,10 @@ gdf_error gdf_jaccard(gdf_graph *graph,
* @return Error code
*/
gdf_error gdf_jaccard_list(gdf_graph *graph,
gdf_column *weights,
gdf_column *first,
gdf_column *second,
gdf_column *result);
gdf_column *weights,
gdf_column *first,
gdf_column *second,
gdf_column *result);

/**
* Computes the Overlap Coefficient for every pair of vertices in the graph which are
Expand Down Expand Up @@ -167,6 +167,6 @@ gdf_error gdf_overlap_list(gdf_graph *graph,
gdf_column *result);

gdf_error gdf_louvain(gdf_graph *graph,
void *final_modularity,
void *num_level,
gdf_column *louvain_parts);
void *final_modularity,
void *num_level,
gdf_column *louvain_parts);
Loading