-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor mg symmetrize tests #2278
Refactor mg symmetrize tests #2278
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2278 +/- ##
=============================================
Coverage 63.97% 63.97%
=============================================
Files 100 100
Lines 4436 4436
=============================================
Hits 2838 2838
Misses 1598 1598 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the updated testing refactoring, the main logic of the tests is intact with improved naming and relevant helpers. The debugging code if symmetrized edges aren't present also helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No recommendations here. looks great.
@gpucibot merge |
This PR refactors and fixes mg symmetrize tests
closes #2277