Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph primitives API updates #2220

Merged
merged 10 commits into from
Apr 19, 2022

Conversation

seunghwak
Copy link
Contributor

Partially address #2003.

  1. Renumber VertexFrontier & SortedUniqueKeyBucket to vertex_frontier_t & sorted_unique_key_bucket_t to be consistent with the naming schemes for graph_t & graph_view_t.
  2. vertex_frontier_t to take number of buckets as an input parameter (instead of non-type template parameter) and rename get_bucket to bucket.
  3. Use constexpr size_t instead of enum calss for bucket indices to avoid unnecessary type casting.
  4. Update fill() of edge_partition_src|dst_property_t to take handle instead of stream to be consistent with other member functions (e.g. clear())
  5. Remove ..._v primitives that working on a subset of local vertices.
  6. Update v_op to take vertex ID (to be consistent with e_op which takes source & destination IDs).
  7. Other miscellaneous clean-ups.

@seunghwak seunghwak requested a review from a team as a code owner April 12, 2022 19:53
@seunghwak seunghwak self-assigned this Apr 12, 2022
@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function breaking Breaking change labels Apr 12, 2022
@seunghwak seunghwak added this to the 22.06 milestone Apr 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #2220 (cb94465) into branch-22.06 (38be932) will increase coverage by 0.04%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06    #2220      +/-   ##
================================================
+ Coverage         70.82%   70.86%   +0.04%     
================================================
  Files               170      170              
  Lines             11036    11036              
================================================
+ Hits               7816     7821       +5     
+ Misses             3220     3215       -5     
Impacted Files Coverage Δ
python/cugraph/cugraph/structure/hypergraph.py 90.00% <ø> (ø)
.../cugraph/tests/test_edge_betweenness_centrality.py 84.93% <0.00%> (+0.60%) ⬆️
...graph/cugraph/tests/test_betweenness_centrality.py 83.01% <0.00%> (+0.62%) ⬆️
python/cugraph/cugraph/tests/test_graph_store.py 100.00% <0.00%> (+1.56%) ⬆️
python/cugraph/cugraph/tests/test_utils.py 75.55% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7030b83...cb94465. Read the comment docs.

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 886c724 into rapidsai:branch-22.06 Apr 19, 2022
@seunghwak seunghwak deleted the enh_vertex_frontier branch August 11, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants