Branch 22.06 MNMG bug work and support for Undirected Graphs #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnke2016
reviewed
Apr 11, 2022
jnke2016
reviewed
Apr 11, 2022
jnke2016
reviewed
Apr 11, 2022
rlratzel
requested changes
Apr 19, 2022
python/cugraph/cugraph/structure/graph_implementation/simpleDistributedGraph.py
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2215 +/- ##
================================================
+ Coverage 70.82% 70.93% +0.11%
================================================
Files 170 172 +2
Lines 11036 11341 +305
================================================
+ Hits 7816 8045 +229
- Misses 3220 3296 +76
Continue to review full report at Codecov.
|
|
rerun tests |
1 similar comment
|
rerun tests |
rlratzel
requested changes
Apr 29, 2022
| @@ -56,7 +68,7 @@ def test_dask_katz_centrality(dask_client): | |||
| from cugraph.tests import utils | |||
| NM = utils.read_csv_for_nx(input_data_path) | |||
| Gnx = nx.from_pandas_edgelist( | |||
| NM, create_using=nx.DiGraph(), source="0", target="1" | |||
| NM, create_using=nx.Graph(directed=directed), source="0", target="1" | |||
There was a problem hiding this comment.
Since this is NetworkX, it needs to stay nx.DiGraph()
Comment on lines
126
to
128
| # FIXME: uddaskGraphFromDataset returns an undirected Graph, which Louvain | ||
| # is currently accepting. In the future, an MNMG symmeterize will | ||
| # need to be called to create a Graph for Louvain. |
There was a problem hiding this comment.
Is this FIXME needed? It's saying an undirected graph needs to be symmetrized, which it already is.
…ith renumber False
rlratzel
approved these changes
May 3, 2022
jnke2016
approved these changes
May 3, 2022
|
@gpucibot merge |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve #2191 and contains code to allow passing undirected graphs to algorithms. It includes tests and comments for this changes. Once reviewed,
This will be applied to the other algorithms that allow undirected graphs. That is issue #2015