Labeling algorithm updates for C API #2185
Conversation
1) Add C API definition/implementation/testing for WCC 2) Add C API definition for SCC 3) Update test utilities to support symmetric graph property
ChuckHastings
added
2 - In Progress
improvement
| if constexpr (!cugraph::is_candidate<vertex_t, edge_t, weight_t>::value) { | ||
| unsupported(); | ||
| } else { | ||
| // WCC expects store_transposed == false |
There was a problem hiding this comment.
Fixed in latest push
| struct wcc_functor : public cugraph::c_api::abstract_functor { | ||
| raft::handle_t const& handle_; | ||
| cugraph::c_api::cugraph_graph_t* graph_; | ||
| bool do_expensive_check_; |
There was a problem hiding this comment.
In latest push
| struct scc_functor : public cugraph::c_api::abstract_functor { | ||
| raft::handle_t const& handle_; | ||
| cugraph::c_api::cugraph_graph_t* graph_; | ||
| bool do_expensive_check_; |
There was a problem hiding this comment.
in latest push
| TRUE, | ||
| alpha, | ||
| epsilon, | ||
| max_iterations); |
There was a problem hiding this comment.
Isn't the updates in this file from the eigenvector C API PR?
There was a problem hiding this comment.
I had to modify the call to create_mg_test_graph and create_test_graph (the SG version) to add the is_symmetric parameter. This required me to change all of the C unit tests. Not quite sure why the indentation changed. Perhaps an upstream change in the clang format parameters?
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2185 +/- ##
================================================
+ Coverage 70.82% 70.86% +0.04%
================================================
Files 170 170
Lines 11036 11036
================================================
+ Hits 7816 7821 +5
+ Misses 3220 3215 -5
Continue to review full report at Codecov.
|
|
@gpucibot merge |
Several things bundled here:
is_symmetricpropertyNOT_IMPLEMENTEDI could add some mock data returns, although the output from SCC is the same as the output from WCC. So python testing could just call WCC instead until there is an SCC implementation.