Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gather one hop neighbors #2117

Merged
merged 12 commits into from
Mar 21, 2022
Merged

Gather one hop neighbors #2117

merged 12 commits into from
Mar 21, 2022

Conversation

kaatish
Copy link
Collaborator

@kaatish kaatish commented Mar 15, 2022

Add utilities to enable multi gpu gathering of adjacency lists to be used for mnmg sampling.

@kaatish kaatish requested review from a team as code owners March 15, 2022 13:55
@kaatish kaatish self-assigned this Mar 15, 2022
@kaatish kaatish added this to the 22.04 milestone Mar 15, 2022
@kaatish kaatish added feature request New feature or request 3 - Ready for Review non-breaking Non-breaking change labels Mar 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022 •
edited
Loading

Codecov Report

Merging #2117 (ef54588) into branch-22.04 (ab72ed5) will decrease coverage by 18.71%.
The diff coverage is n/a.

❗ Current head ef54588 differs from pull request most recent head 162ab82. Consider uploading reports for the commit 162ab82 to get more accurate results

@@                Coverage Diff                @@
##           branch-22.04    #2117       +/-   ##
=================================================
- Coverage         73.70%   54.98%   -18.72%     
=================================================
  Files               155       12      -143     
  Lines             10373      662     -9711     
=================================================
- Hits               7645      364     -7281     
+ Misses             2728      298     -2430
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py
python/cugraph/cugraph/sampling/__init__.py
python/cugraph/cugraph/sampling/random_walks.py
python/cugraph/cugraph/structure/hypergraph.py
python/cugraph/cugraph/linear_assignment/lap.py
python/cugraph/cugraph/tests/test_sssp.py
python/cugraph/cugraph/link_prediction/jaccard.py
python/cugraph/cugraph/link_prediction/woverlap.py
python/cugraph/cugraph/tests/test_force_atlas2.py
...tests/dask/test_mg_batch_betweenness_centrality.py
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab72ed5...162ab82. Read the comment docs.

seunghwak
seunghwak reviewed Mar 15, 2022
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More reviews coming, but just to quickly resolve potential misunderstanding.

cpp/include/cugraph/detail/decompress_matrix_partition.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/detail/decompress_matrix_partition.cuh Outdated Show resolved Hide resolved
@kaatish kaatish requested a review from a team as a code owner March 16, 2022 14:27
@kaatish kaatish requested a review from seunghwak March 16, 2022 14:28
ajschmidt8
ajschmidt8 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@aschaffer
Copy link
Collaborator

rerun tests

seunghwak
seunghwak reviewed Mar 16, 2022
View reviewed changes
cpp/include/cugraph/detail/decompress_matrix_partition.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/detail/graph_functions.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/detail/graph_functions.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/detail/graph_functions.cuh Show resolved Hide resolved
cpp/include/cugraph/detail/graph_functions.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/detail/graph_functions.cuh Show resolved Hide resolved
cpp/src/sampling/detail/gather_utils_impl.cuh Outdated Show resolved Hide resolved
cpp/src/sampling/detail/gather_utils_impl.cuh Outdated Show resolved Hide resolved
cpp/src/sampling/detail/gather_utils_impl.cuh Outdated Show resolved Hide resolved
cpp/src/sampling/detail/gather_utils_impl.cuh Outdated Show resolved Hide resolved
seunghwak
seunghwak reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few additional suggestions about naming.

cpp/include/cugraph/detail/decompress_matrix_partition.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/detail/decompress_matrix_partition.cuh Outdated Show resolved Hide resolved
@aschaffer aschaffer mentioned this pull request Mar 17, 2022
Closed
seunghwak
seunghwak approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor suggestions about variable/function names. LGTM otherwise.

cpp/include/cugraph/detail/graph_functions.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/detail/graph_functions.cuh Show resolved Hide resolved
cpp/include/cugraph/detail/graph_functions.cuh Outdated Show resolved Hide resolved
@aschaffer
Copy link
Collaborator

rerun tests

1 similar comment
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6c3a469 into rapidsai:branch-22.04 Mar 21, 2022
@seunghwak seunghwak mentioned this pull request Apr 7, 2022
Merged
rapids-bot bot pushed a commit that referenced this pull request Apr 11, 2022
@seunghwak
renaming detail space functions (#2212)
cd9d7ed 
To address the comment in #2117 (comment)

Device kernels for graph primitives for different vertex degree ranges had been named `for_all_major_for_all_nbr_...`. This is subject to naming conflicts and @kaatish established a better naming convention to avoid this. This PR applies the same naming conventions to other graph primitives.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)

Approvers:
  - Kumar Aatish (https://github.com/kaatish)
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #2212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@aschaffer aschaffer aschaffer approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@kaatish kaatish

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
22.04
Development

Successfully merging this pull request may close these issues.
7 participants
@kaatish @codecov-commenter @aschaffer @BradReesWork @ajschmidt8 @ChuckHastings @seunghwak