Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conda compilers #2101

Merged
merged 3 commits into from
May 23, 2022
Merged

Use conda compilers #2101

merged 3 commits into from
May 23, 2022

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Mar 2, 2022 •
edited
Loading

This PR enables the usage of conda compilers to build conda packages. This is required to use mambabuild

@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022 •
edited
Loading

Codecov Report

Merging #2101 (fbbdcbd) into branch-22.06 (916dc5c) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06    #2101      +/-   ##
================================================
- Coverage         63.97%   63.69%   -0.29%     
================================================
  Files               100      100              
  Lines              4436     4481      +45     
================================================
+ Hits               2838     2854      +16     
- Misses             1598     1627      +29
Impacted Files Coverage Δ
...n/pylibcugraph/pylibcugraph/utilities/api_tools.py 88.05% <0.00%> (-7.47%) ⬇️
python/cugraph/cugraph/traversal/bfs.py 78.87% <0.00%> (-7.13%) ⬇️
python/cugraph/cugraph/gnn/graph_store.py 80.00% <0.00%> (-2.61%) ⬇️
python/cugraph/cugraph/dask/traversal/bfs.py 14.75% <0.00%> (-1.92%) ⬇️
python/cugraph/cugraph/dask/community/louvain.py 24.24% <0.00%> (-1.57%) ⬇️
python/cugraph/cugraph/dask/traversal/sssp.py 21.42% <0.00%> (-1.08%) ⬇️
python/cugraph/cugraph/structure/number_map.py 65.83% <0.00%> (-0.96%) ⬇️
python/cugraph/cugraph/sampling/node2vec.py 81.81% <0.00%> (ø)
python/cugraph/cugraph/dask/link_analysis/hits.py 18.75% <0.00%> (ø)
...aph/cugraph/dask/sampling/neighborhood_sampling.py 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916dc5c...fbbdcbd. Read the comment docs.

@jjacobelli
Copy link
Contributor Author

rerun tests

@jjacobelli jjacobelli force-pushed the conda-comp branch 2 times, most recently from 7fd1672 to 46d934f Compare March 7, 2022 14:31
@rlratzel
Copy link
Contributor

rlratzel commented Mar 9, 2022

Updated build env has compatible NetworkX/SciPy packages.

rerun tests

@jjacobelli
Copy link
Contributor Author

rerun tests

@BradReesWork BradReesWork added this to the 22.04 milestone Mar 11, 2022
@jjacobelli jjacobelli changed the base branch from branch-22.04 to branch-22.06 March 24, 2022 09:16
@jjacobelli jjacobelli removed this from the 22.04 milestone Mar 24, 2022
@BradReesWork BradReesWork added this to the 22.06 milestone Mar 24, 2022
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@jjacobelli
Use conda compilers
cba547e 
Signed-off-by: Jordan Jacobelli <[email protected]>
jjacobelli
jjacobelli commented May 16, 2022
View reviewed changes
python/pylibcugraph/setup.py
@@ -122,7 +122,7 @@ def run(self):
os.path.join(os.sys.prefix, "lib")
],
libraries=['cudart', 'cusparse', 'cusolver', 'cugraph', 'nccl',
'cugraph_c'],
'cugraph_c', 'cublas'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As our CI system force us to rebuild Python packages in GPU tests stage, we are compiling using CUDA 11.0 and we are linking to libcusolver.so.10 which does not contain the libcublas. We need to explicitly link to libcublas to fix this

@jjacobelli jjacobelli marked this pull request as ready for review May 20, 2022 19:37
@jjacobelli jjacobelli requested review from a team as code owners May 20, 2022 19:37
ajschmidt8
ajschmidt8 approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, pending the removal of the -conda-comp suffix for the SCCACHE_S3_KEY_PREFIX

@jjacobelli
Revert reordering in conda recipes
fbbdcbd 
Signed-off-by: Jordan Jacobelli <[email protected]>
@jjacobelli
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9b1d189 into rapidsai:branch-22.06 May 23, 2022
@vyasr vyasr mentioned this pull request Jul 1, 2022
Merged
rapids-bot bot pushed a commit that referenced this pull request Jul 7, 2022
@vyasr
Add conda compilers to env file (#2384)
526fbfc 
The conda compilers are required as of #2101 so they should be in the env file to ensure that all library paths etc are correct during compilation.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.06
Development

Successfully merging this pull request may close these issues.
5 participants
@jjacobelli @codecov-commenter @rlratzel @ajschmidt8 @BradReesWork