Graph prmitives API update #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate_edge_partition_src_dst_property)
seunghwak
added
2 - In Progress
improvement
…cue_by_src|dst_key_e
seunghwak
changed the title
|
@kaatish @aschaffer FYI: this may possibly break graph-ops if they are directly using graph primitives. |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2100 +/- ##
===============================================
Coverage ? 73.99%
===============================================
Files ? 157
Lines ? 10496
Branches ? 0
===============================================
Hits ? 7767
Misses ? 2729
Partials ? 0 Continue to review full report at Codecov.
|
aschaffer
approved these changes
Mar 15, 2022
ChuckHastings
approved these changes
Mar 18, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the series of planned PRs to address #2003
We want to consistently use source & destination (or src & dst as abbreviation) instead of mixing source/destination and row/column and better group function/class/parameter names based on the concept of vertex partition and edge partition.
This PR renames
row/col_properties_ttoedge_partition_src/dst_property_tand
copy_to_adj_matrix_partition_row/coltoupdate_edge_partition_src/dst_propertyand
transform_reduce_by_adj_matrix_row|col_key_etotransform_reduce_by_src|dst_key_eand fix resulting compile errors.
Possibly a breaking change (even though I am not aware of any external projects to be affected).