-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating a few headers that have been renamed in raft #2090
Updating a few headers that have been renamed in raft #2090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be pointed back at RAFT 22.04 now?
Looks good otherwise.
@ChuckHastings assuming CI passes, it should be ready to merge |
Not sure what could be causing this failure off the top of my head, but with my (somewhat limited) knowledge of CPM, I'm guessing from this CI log it's possible that Thrust is being pulled in transitively from both |
rerun tests |
The failing CI should be fixed by rapidsai/raft#532 |
rerun tests |
1 similar comment
rerun tests |
Rerunning tests since #2095 has been merged which is needed by CI for this PR. rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2090 +/- ##
===============================================
Coverage ? 73.63%
===============================================
Files ? 154
Lines ? 10327
Branches ? 0
===============================================
Hits ? 7604
Misses ? 2723
Partials ? 0 Continue to review full report at Codecov.
|
@ChuckHastings @rlratzel This is ready to be merged and is not dependent on any further changes in RAFT. Just to get this in quickly, I can also open a follow-on PR to remove the existing |
@gpucibot merge |
No description provided.