Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a few headers that have been renamed in raft #2090

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 22, 2022

No description provided.

@cjnolet cjnolet requested review from a team as code owners February 22, 2022 21:46
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be pointed back at RAFT 22.04 now?

Looks good otherwise.

@cjnolet
Copy link
Member Author

cjnolet commented Feb 27, 2022

@ChuckHastings assuming CI passes, it should be ready to merge

@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 27, 2022
@ChuckHastings ChuckHastings added this to the 22.04 milestone Feb 27, 2022
@cjnolet cjnolet requested a review from a team as a code owner February 27, 2022 01:15
@cjnolet
Copy link
Member Author

cjnolet commented Feb 27, 2022

Not sure what could be causing this failure off the top of my head, but with my (somewhat limited) knowledge of CPM, I'm guessing from this CI log it's possible that Thrust is being pulled in transitively from both rmm and raft, which is causing the target be defined twice? @robertmaynard is it possible this could be causing the issue here? I notice cugraph-ops is bringing in rmm here so maybe that's propagating to cugraph as a transitive dependency?

@robertmaynard
Copy link
Contributor

rerun tests

@robertmaynard
Copy link
Contributor

The failing CI should be fixed by rapidsai/raft#532

@ChuckHastings
Copy link
Collaborator

rerun tests

1 similar comment
@ChuckHastings
Copy link
Collaborator

rerun tests

@rlratzel
Copy link
Contributor

rlratzel commented Mar 1, 2022

Rerunning tests since #2095 has been merged which is needed by CI for this PR.

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@cf7b174). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #2090   +/-   ##
===============================================
  Coverage                ?   73.63%           
===============================================
  Files                   ?      154           
  Lines                   ?    10327           
  Branches                ?        0           
===============================================
  Hits                    ?     7604           
  Misses                  ?     2723           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7b174...9c04655. Read the comment docs.

@cjnolet
Copy link
Member Author

cjnolet commented Mar 1, 2022

@ChuckHastings @rlratzel This is ready to be merged and is not dependent on any further changes in RAFT. Just to get this in quickly, I can also open a follow-on PR to remove the existing git_helpers.py in ci/utils if that would be helpful (I propose we keep the changes to the copyright checker script since they match cuml and raft).

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cef4924 into rapidsai:branch-22.04 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants