Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for recent RAFT API changes #2065

Closed
wants to merge 2 commits into from
Closed

Updates for recent RAFT API changes #2065

wants to merge 2 commits into from

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 9, 2022

No description provided.

@cjnolet cjnolet requested a review from a team as a code owner February 9, 2022 16:39
@BradReesWork BradReesWork added Fix non-breaking Non-breaking change labels Feb 9, 2022
@BradReesWork BradReesWork added this to the 22.04 milestone Feb 9, 2022
@BradReesWork BradReesWork added the improvement Improvement / enhancement to an existing function label Feb 9, 2022
@seunghwak
Copy link
Contributor

Not a complaint to this PR, but are we using cpp/src/utilities/spmv_1D.cu anywhere? Can't we just delete this? @ChuckHastings

seunghwak
seunghwak approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@ChuckHastings
Copy link
Collaborator

Not a complaint to this PR, but are we using cpp/src/utilities/spmv_1D.cu anywhere? Can't we just delete this? @ChuckHastings

Good point. Will create a separate PR for that.

@ChuckHastings ChuckHastings mentioned this pull request Feb 9, 2022
Merged
@cjnolet
Copy link
Member Author

cjnolet commented Feb 9, 2022

This went down a bad path on the raft side and I realized more changes were needed (including removing using namespace across the spectral header files). I'm closing this for #2067

@cjnolet cjnolet closed this Feb 9, 2022
rapids-bot bot pushed a commit that referenced this pull request Feb 10, 2022
@ChuckHastings
remove unused spmv functions (#2066)
3187fbf 
From comment in #2065, removing SPMV calls which are obsolete.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #2066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.04
Development

Successfully merging this pull request may close these issues.
4 participants
@cjnolet @seunghwak @ChuckHastings @BradReesWork