Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pylibcugraph utility for setting up return array values #2060

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Feb 5, 2022

Refactored common code that copies device arrays returned by cugraph_* C APIs to cupy arrays into a utility function. This eliminates a significant amount of repeated code, and will be especially helpful as new pylibcugraph APIs are added that copy the existing patterns.

Tested by running existing pylibcugraph unit tests.

…* C APIs to cupy arrays into a utility function.
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python labels Feb 5, 2022
@rlratzel rlratzel added this to the 22.04 milestone Feb 5, 2022
@rlratzel rlratzel self-assigned this Feb 5, 2022
@rlratzel rlratzel requested a review from a team as a code owner February 5, 2022 21:05
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@9bc960e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #2060   +/-   ##
===============================================
  Coverage                ?   73.55%           
===============================================
  Files                   ?      156           
  Lines                   ?    10295           
  Branches                ?        0           
===============================================
  Hits                    ?     7573           
  Misses                  ?     2722           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc960e...69b41fb. Read the comment docs.

Copy link
Contributor

@betochimas betochimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to expand utils.pyx for future wrappers, so this looks great

@rlratzel
Copy link
Contributor Author

rlratzel commented Feb 8, 2022

Tests failed because cudf raised an ImportError due to a missing symbol. Rerunning to get the latest cudf build.

rerun tests

@rlratzel
Copy link
Contributor Author

rlratzel commented Feb 9, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ff88061 into rapidsai:branch-22.04 Feb 9, 2022
@rlratzel rlratzel deleted the branch-22.04-pylibcugraph_refactoring branch June 17, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants