Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of remaining DiGraph Python mentions #2049

Merged
merged 11 commits into from
Feb 4, 2022

Conversation

betochimas
Copy link
Contributor

Closes #2005 when merged

@betochimas betochimas requested a review from a team as a code owner January 29, 2022 01:16
@betochimas betochimas marked this pull request as draft January 29, 2022 01:17
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python labels Jan 31, 2022
@rlratzel rlratzel added this to the 22.04 milestone Jan 31, 2022
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good so far, and here's some early feedback. The main goal is that the cugraph code should not be using deprecated code, and this PR accomplishes that, but we may want to roll back a few of these other changes to allow users to continue to use the deprecated classes in case they haven't migrated yet, but we can discuss offline..

python/cugraph/cugraph/components/connectivity.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/structure/graph_classes.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/test_balanced_cut.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/utils.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/traversal/bfs.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #2049 (6c6c653) into branch-22.04 (2e781c1) will decrease coverage by 0.15%.
The diff coverage is 52.21%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04    #2049      +/-   ##
================================================
- Coverage         73.26%   73.11%   -0.16%     
================================================
  Files               151      155       +4     
  Lines              9736    10061     +325     
================================================
+ Hits               7133     7356     +223     
- Misses             2603     2705     +102     
Impacted Files Coverage Δ
python/cugraph/cugraph/components/connectivity.py 95.00% <ø> (ø)
python/cugraph/cugraph/structure/graph_classes.py 78.01% <ø> (ø)
...ure/graph_implementation/simpleDistributedGraph.py 22.85% <0.00%> (-0.17%) ⬇️
python/cugraph/cugraph/tests/dask/test_mg_comms.py 19.60% <0.00%> (ø)
python/cugraph/cugraph/traversal/bfs.py 86.00% <ø> (ø)
python/cugraph/cugraph/traversal/sssp.py 92.23% <ø> (ø)
python/cugraph/cugraph/generators/rmat.py 33.65% <36.36%> (-0.80%) ⬇️
python/cugraph/cugraph/structure/convert_matrix.py 62.01% <47.61%> (-14.66%) ⬇️
python/cugraph/cugraph/utilities/utils.py 70.30% <71.42%> (-0.07%) ⬇️
python/cugraph/cugraph/tests/test_balanced_cut.py 100.00% <100.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e781c1...6c6c653. Read the comment docs.

python/cugraph/cugraph/generators/rmat.py Show resolved Hide resolved
python/cugraph/cugraph/tests/generators/test_rmat.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/utils.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/utils.py Outdated Show resolved Hide resolved
@rlratzel rlratzel marked this pull request as ready for review February 4, 2022 16:17
@rlratzel
Copy link
Contributor

rlratzel commented Feb 4, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9bc960e into rapidsai:branch-22.04 Feb 4, 2022
@rlratzel rlratzel changed the title [WIP] Removal of remaining DiGraph Python mentions Removal of remaining DiGraph Python mentions Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cuGraph uses deprecated DiGraph class
3 participants