Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] add libcugraphops as a dependency of cugraph #2019

Merged
merged 14 commits into from
Feb 12, 2022
Merged

[FEA] add libcugraphops as a dependency of cugraph #2019

merged 14 commits into from
Feb 12, 2022

Conversation

MatthiasKohl
Copy link
Contributor

@MatthiasKohl MatthiasKohl commented Jan 19, 2022 •
edited by rlratzel
Loading

We need to do several things:

  • Add libcugraphops to conda (both in the cugraph recipe as well as build environment)
  • Add libcugraphops to cmake (I added a new thirdparty include here)
  • Ensure that the right headers and objects are added in cmake

For now, this is a work in progress since libcugraphops doesn't seem available on anaconda yet.

@MatthiasKohl MatthiasKohl requested review from a team as code owners January 19, 2022 17:16
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 20, 2022
@BradReesWork BradReesWork added this to the 22.02 milestone Jan 20, 2022
@BradReesWork BradReesWork added 4 - Waiting on Author DO NOT MERGE Hold off on merging; see PR for details labels Jan 20, 2022
@ajschmidt8
Copy link
Member

Please consider using GitHub's Draft PR feature instead of WIP tags in the future. Draft PRs have the benefit of preventing notifications to codeowners until PRs are marked Ready for Review, which helps cut down on excessive notifications for PRs that are still being worked on. CI will still run on Draft PRs.

Some useful information about Draft PRs:

@BradReesWork BradReesWork modified the milestones: 22.02, 22.04 Jan 26, 2022
@MatthiasKohl MatthiasKohl requested review from a team as code owners January 31, 2022 18:06
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@MatthiasKohl MatthiasKohl marked this pull request as draft January 31, 2022 18:08
@MatthiasKohl
Copy link
Contributor Author

@ajschmidt8 sorry about this, I wasn't aware of the feature, I'll try to use it from now on

@MatthiasKohl MatthiasKohl changed the base branch from branch-22.02 to branch-22.04 January 31, 2022 18:11
@BradReesWork BradReesWork removed the DO NOT MERGE Hold off on merging; see PR for details label Feb 1, 2022
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022 •
edited
Loading

Codecov Report

Merging #2019 (cec7920) into branch-22.04 (3187fbf) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head cec7920 differs from pull request most recent head 2680bb3. Consider uploading reports for the commit 2680bb3 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04    #2019      +/-   ##
================================================
+ Coverage         73.51%   73.55%   +0.04%     
================================================
  Files               156      156              
  Lines             10295    10295              
================================================
+ Hits               7568     7573       +5     
+ Misses             2727     2722       -5
Impacted Files Coverage Δ
.../cugraph/tests/test_edge_betweenness_centrality.py 84.93% <0.00%> (+0.60%) ⬆️
...graph/cugraph/tests/test_betweenness_centrality.py 83.01% <0.00%> (+0.62%) ⬆️
python/cugraph/cugraph/tests/test_graph_store.py 100.00% <0.00%> (+1.56%) ⬆️
python/cugraph/cugraph/tests/test_utils.py 75.55% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3187fbf...2680bb3. Read the comment docs.

@MatthiasKohl MatthiasKohl marked this pull request as ready for review February 3, 2022 09:02
robertmaynard
robertmaynard approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes LGTM

@BradReesWork BradReesWork added feature request New feature or request and removed 4 - Waiting on Author improvement Improvement / enhancement to an existing function labels Feb 3, 2022
@BradReesWork BradReesWork changed the title [WIP] [FEA] add libcugraphops as a dependency of cugraph [FEA] add libcugraphops as a dependency of cugraph Feb 3, 2022
@ChuckHastings
Copy link
Collaborator

rerun tests

1 similar comment
@ChuckHastings
Copy link
Collaborator

rerun tests

@kaatish kaatish requested a review from jjacobelli February 10, 2022 18:41
@MatthiasKohl
Copy link
Contributor Author

rerun tests

@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 18ac2c2 into rapidsai:branch-22.04 Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

@rlratzel rlratzel rlratzel approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
22.04
Development

Successfully merging this pull request may close these issues.
8 participants
@MatthiasKohl @ajschmidt8 @BradReesWork @codecov-commenter @ChuckHastings @rlratzel @robertmaynard @jjacobelli