Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review] Add optimized 2x string column renumbering code #1996

Merged
merged 6 commits into from
Jan 26, 2022
Merged

[Review] Add optimized 2x string column renumbering code #1996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3c9e195
Add opt string renumbering code with cudf concurrent hashmap files
chirayuG-nvidia Dec 21, 2021
739cb8f
remove unused cudf hash table files
chirayuG-nvidia Jan 26, 2022
f52ec50
Fix renumbering with review comments: remove prints, add RAFT handle,…
chirayuG-nvidia Jan 26, 2022
8ed515b
remove unused headers
chirayuG-nvidia Jan 26, 2022
1b62a32
Format renumbering implementation with clang
chirayuG-nvidia Jan 26, 2022
54d6532
update copyright header on cmake file
chirayuG-nvidia Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cpp/libcugraph_etl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#=============================================================================
# Copyright (c) 2021, NVIDIA CORPORATION.
# Copyright (c) 2021-2022, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -119,6 +119,10 @@ target_compile_options(cugraph_etl
PRIVATE "$<$<COMPILE_LANGUAGE:CXX>:${CUGRAPH_ETL_CXX_FLAGS}>"
)

target_compile_options(cugraph_etl PRIVATE $<$<COMPILE_LANGUAGE:CUDA>:
--expt-relaxed-constexpr
--expt-extended-lambda
>)
################################################################################
# - ETL include paths --------------------------------------------------------
target_include_directories(cugraph_etl
Expand Down
7 changes: 5 additions & 2 deletions cpp/libcugraph_etl/include/cugraph_etl/functions.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021, NVIDIA CORPORATION.
* Copyright (c) 2021-2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -19,6 +19,8 @@
#include <cudf/table/table.hpp>
#include <cudf/types.hpp>

#include <raft/handle.hpp>

namespace cugraph {
namespace etl {

Expand Down Expand Up @@ -47,7 +49,8 @@ namespace etl {
*/
std::
tuple<std::unique_ptr<cudf::column>, std::unique_ptr<cudf::column>, std::unique_ptr<cudf::table>>
renumber_cudf_tables(cudf::table_view const& src_table,
renumber_cudf_tables(raft::handle_t const& handle,
cudf::table_view const& src_table,
cudf::table_view const& dst_table,
cudf::type_id dtype);

Expand Down
Loading