Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass RMM memory allocator to cuco #1994

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Pass RMM memory allocator to cuco #1994

merged 1 commit into from
Jan 3, 2022

Conversation

seunghwak
Copy link
Contributor

There was one place still using CUDA memory allocator in using cuco::static_map. This PR fixes this.

@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 16, 2021
@seunghwak seunghwak added this to the 22.02 milestone Dec 16, 2021
@seunghwak seunghwak self-assigned this Dec 16, 2021
@seunghwak seunghwak requested a review from a team as a code owner December 16, 2021 23:14
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@dec389c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #1994   +/-   ##
===============================================
  Coverage                ?   70.50%           
===============================================
  Files                   ?      142           
  Lines                   ?     8880           
  Branches                ?        0           
===============================================
  Hits                    ?     6261           
  Misses                  ?     2619           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec389c...1c03998. Read the comment docs.

@seunghwak seunghwak mentioned this pull request Dec 21, 2021
Merged
2 tasks
@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 938e53f into rapidsai:branch-22.02 Jan 3, 2022
@seunghwak seunghwak deleted the bug_memory branch January 27, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@kaatish kaatish kaatish approved these changes

Assignees

@seunghwak seunghwak

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.02
Development

Successfully merging this pull request may close these issues.
4 participants
@seunghwak @codecov-commenter @ChuckHastings @kaatish