fix bug when calculating the number of vertices #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build timed out for some reason. rerun tests |
rlratzel
approved these changes
Dec 16, 2021
|
@gpucibot merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-22.02 #1992 +/- ##
===============================================
Coverage ? 70.50%
===============================================
Files ? 142
Lines ? 8880
Branches ? 0
===============================================
Hits ? 6261
Misses ? 2619
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of vertices calculation in the previous implementation relied on getting the max of the source and destination's max. Each worker computes the max of its partition however, workers having empty partition attempt to do the same causing an error. This seems to be caused by a recent change on how dask handle empty partitions with the
max()function.This PR calculates the total number of vertices by summing each partition's number of vertices which is inspired from our code base.