Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing RAFT changes hide implementation details for communicator #1983

Closed

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Dec 7, 2021

No description provided.

@cjnolet cjnolet requested a review from a team as a code owner December 7, 2021 19:38
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@BradReesWork BradReesWork added this to the 22.02 milestone Jan 18, 2022
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 18, 2022
@BradReesWork
Copy link
Member

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Jan 18, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Jan 19, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Jan 19, 2022

@robertmaynard, it looks like we're getting some cuco compile errors in CI here:

11:42:45 ../include/cugraph/prims/copy_v_transform_reduce_key_aggregated_out_nbr.cuh(293): error: no instance of function template "cuco::static_map<Key, Value, Scope, Allocator>::insert [with Key=int32_t, Value=float, Scope=cuda::std::__4::__detail::thread_scope_device, Allocator=rmm::mr::stream_allocator_adaptor<rmm::mr::polymorphic_allocator<char>>]" matches the argument list

I recall the cuco git hash was updated twice yesterday, once by @seunghwak and in rapidsai/raft#446. Can you confirm it's currently correct?

@cjnolet
Copy link
Member Author

cjnolet commented Jan 19, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Jan 19, 2022

@robertmaynard, @seunghwak disregard, I think my branch was out of sync.

@cjnolet
Copy link
Member Author

cjnolet commented Jan 19, 2022

rerun tests

2 similar comments
@cjnolet
Copy link
Member Author

cjnolet commented Jan 20, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Jan 20, 2022

rerun tests

@cjnolet cjnolet changed the base branch from branch-22.02 to branch-22.04 January 25, 2022 21:35
@cjnolet cjnolet requested review from a team as code owners January 25, 2022 21:35
@BradReesWork BradReesWork modified the milestones: 22.02, 22.04 Jan 26, 2022
@ajschmidt8 ajschmidt8 removed the request for review from a team January 26, 2022 19:01
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@cjnolet
Copy link
Member Author

cjnolet commented Jan 26, 2022

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@42eaf3c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #1983   +/-   ##
===============================================
  Coverage                ?   73.30%           
===============================================
  Files                   ?      151           
  Lines                   ?     9736           
  Branches                ?        0           
===============================================
  Hits                    ?     7137           
  Misses                  ?     2599           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42eaf3c...1cea8ed. Read the comment docs.

@cjnolet
Copy link
Member Author

cjnolet commented Jan 30, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Feb 1, 2022

This has been merged on the raft side. Closing

@cjnolet cjnolet closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants