Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown the connected scheduler and workers #1980

Merged

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Dec 3, 2021

The MNMG tests/benchmarks runs rely on killing the dask cluster process ID to stop all python/dask processes
This PR uses client.shutdown to shutdown the connected scheduler and workers

@jnke2016 jnke2016 requested a review from a team as a code owner December 3, 2021 20:51
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@9ddea03). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #1980   +/-   ##
===============================================
  Coverage                ?   70.50%           
===============================================
  Files                   ?      142           
  Lines                   ?     8880           
  Branches                ?        0           
===============================================
  Hits                    ?     6261           
  Misses                  ?     2619           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddea03...a7b9835. Read the comment docs.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 4, 2021
@rlratzel
Copy link
Contributor

rlratzel commented Dec 4, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5630829 into rapidsai:branch-22.02 Dec 4, 2021
@BradReesWork BradReesWork added this to the 22.02 milestone Jan 19, 2022
@jnke2016 jnke2016 deleted the shutdown_scheduler_workers branch September 24, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants