Updates to support correct comparisons of cuDF Series with different names #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradReesWork
approved these changes
Nov 4, 2021
ChuckHastings
approved these changes
Nov 4, 2021
jnke2016
approved these changes
Nov 4, 2021
|
@gpucibot merge |
ajschmidt8
approved these changes
Nov 4, 2021
This was referenced Dec 22, 2021
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Dec 23, 2021
I see CI timeouts occurring at the step where local conda artifacts for libcudf and libcudf_kafka are installed. This PR uses `gpuci_mamba_retry` instead of `conda` to install those local artifacts (this change was also recently made in rapidsai/cugraph#1928). Example timeouts: - https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-gpu-test/CUDA=11.5,GPU_LABEL=driver-495,LINUX_VER=ubuntu20.04,PYTHON=3.8/5764/console - https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-gpu-test/CUDA=11.5,GPU_LABEL=driver-495,LINUX_VER=ubuntu20.04,PYTHON=3.8/5773/console Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #9951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuDF PR rapidsai/cudf#9542 fixes a problem where comparisons between Series objects would return
Trueeven if the Series names were different, which is inconsistent with Pandas. Some cuGraph tests relied on the old behavior which ignored names and were failing.This PR updates those tests to use the proper comparison utility provided by cuDF to restore the intended behavior of the test assertions.
This PR also updates the
gpuCI script to usemambafor an install step to hopefully speed up CI runs.