Update graph_classes.py #1914
Closed
Update graph_classes.py #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify exception message on Graph constructor. Colleague lost some time tracing this!
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Thank you for submitting this and we're very sorry for the lost time. |
|
Thank you for the quick merge! We're migrating some graph processing codebases to cuGraph and enjoying so far. I'll do a sweep through exception messages and propose any other related clarifications in a separate PR. |
rlratzel
requested changes
Oct 29, 2021
| @@ -70,7 +70,7 @@ def __init__(self, m_graph=None, directed=False): | |||
| edge_attr=weights) | |||
| else: | |||
| msg = ( | |||
| "Graph can only be initialized using MultiGraph " | |||
| "Graph can only be initialized using cuGraph or networkX MultiGraph object." | |||
There was a problem hiding this comment.
NetworkX MultiGraph graphs are not yet supported.
>>> import pandas as pd
>>> import networkx as nx
>>>
>>> import cudf
>>> import cugraph
>>>
>>> df = pd.DataFrame({"src":[0,1,2],"dst":[1,2,0]})
>>>
>>> nxMG = nx.from_pandas_edgelist(df, create_using=nx.MultiGraph,
... source="src", target="dst")
>>>
>>> cgMG = cugraph.MultiGraph()
>>> cgMG.from_pandas_edgelist(df, source="src", destination="dst")
>>>
>>> G = cugraph.Graph(m_graph=nxMG)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/opt/conda/envs/rapids/lib/python3.8/site-packages/cugraph-21.12.0a0+57.gcb65876a-py3.8-linux-x86_64.egg/cugraph/structure/graph_classes.py", line 62, in __init__
elist = m_graph.view_edge_list()
AttributeError: 'MultiGraph' object has no attribute 'view_edge_list'
>>>
>>> G = cugraph.Graph(m_graph=cgMG)
>>>
Suggested change
| "Graph can only be initialized using cuGraph or networkX MultiGraph object." | |
| "Graph can only be initialized using a cugraph.MultiGraph object." |
|
ok to test |
|
@bmg-pcl - it looks like your change failed our automated style check: so you may have to split the message across two lines. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 5, 2021
…invalid MultiGraph is passed in (#1925) * Updated error message and using a proper TypeError exception when an invalid MultiGraph is passed in. * Added test to verify. This PR replaces #1914 since that one is not passing the style check and the author has not responded. Authors: - Rick Ratzel (https://github.com/rlratzel) Approvers: - Brad Rees (https://github.com/BradReesWork) URL: #1925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify exception message on Graph constructor.
Colleague lost some time tracing this!