Update calls to cuDF Series ctors, bug fix to cugraph.subgraph() for handling non-renumbered Graphs
#1901
Conversation
…that has not been renumbered is handled correctly by cugraph.subgraph()
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1901 +/- ##
===============================================
Coverage ? 70.13%
===============================================
Files ? 143
Lines ? 8812
Branches ? 0
===============================================
Hits ? 6180
Misses ? 2632
Partials ? 0 Continue to review full report at Codecov.
|
…ted from Buffers. Also cleaned up various cython imports and some minor test cleanup.
…ore cleanup to cython imports (still testing).
rlratzel
changed the title
cugraph.subgraph()cugraph.subgraph() for handling non-renumbered Graphs
| from libc.stdint cimport uintptr_t | ||
|
|
||
|
|
||
| cdef move_device_buffer_to_series(unique_ptr[device_buffer] device_buffer_unique_ptr, |
There was a problem hiding this comment.
Question... This implementation generates a column and converts it into a Series. In many of the algorithms we generate a Series using this function to create a column in a data frame.
Would it be better to generate a column and leave it as a column? Perhaps we should have a move_device_buffer_to_series and a move_device_buffer_to_column method?
Or am I reading too much into this?
There was a problem hiding this comment.
Thanks @ChuckHastings , I like that idea and I'm testing out your suggestion now. In the interest of unblocking our other PRs by fixing the CI failures here, I'll ask @BradReesWork to merge this now and then I'll create a follow-up PR that implements your suggestion.
|
@gpucibot merge |
…eries objects (#1915) This is a follow-up PR to address [this feedback](#1901 (comment)) from #1901 This adds a separate cython helper for moving a buffer to a column to allow for a slightly more efficient call where column objects can be used. Authors: - Rick Ratzel (https://github.com/rlratzel) Approvers: - Brad Rees (https://github.com/BradReesWork) - Chuck Hastings (https://github.com/ChuckHastings) - Joseph Nke (https://github.com/jnke2016) URL: #1915
Seriesobjects are constructed fromBuffertypes.ci/gpu/build.shto add the conda envbindir toPATH, since it was not finding the correctcmakeduring a local run.cugraph.subgraph().pytest.inifor users that don't have the required extra pytest plugins installed, left comments in place to for users to re-enable.closes #1908
closes #1899
Note: this PR was originally intended to be two PRs: one for the
subgraphbug fix, and another for thecudf.Seriesupdates. I accidentally pushed the Series updates to the wrong branch, hence this combined PR. I can separate them if reviewing is too difficult.