-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Remove FAISS dependency, inherit other common dependencies from raft #1863
[FEA] Remove FAISS dependency, inherit other common dependencies from raft #1863
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #1863 +/- ##
===============================================
Coverage ? 70.75%
===============================================
Files ? 142
Lines ? 8861
Branches ? 0
===============================================
Hits ? 6270
Misses ? 2591
Partials ? 0 Continue to review full report at Codecov.
|
@trxcllnt is this really a hotfix for 21.10? |
rerun tests |
rerun tests |
rerun tests |
4 similar comments
rerun tests |
rerun tests |
rerun tests |
rerun tests |
We recently merged the PR to raft that establishes multiple output targets- specifically, there is now a libraft-nn package which depends kn FAISS (and which cugraph no longer depends on directly). Does this help at all alleviate the FAISS issue on cugraph? |
rerun tests |
…into fix/build-shared-faiss
@trxcllnt, not sure if it helps but I opened #2009 to fully remove the faiss dependency from cugraph and implement @robertmaynard's recent changes to the raft build. |
rerun tests |
1 similar comment
rerun tests |
This PR has been updated to use rapidsai/raft#428 |
rerun tests |
rerun tests |
1 similar comment
rerun tests |
rerun tests |
1 similar comment
rerun tests |
@gpucibot merge |
Originally this PR was about building FAISS shared libs via CPM, but @rlratzel mentioned cuGraph doesn't need FAISS anymore, and it'd be better if we remove it.
If we need FAISS again in the future, we can add
faiss::faiss
back totarget_link_libraries
without needing extra CPM configuration as it will be available via raft.Edit: Removed more dependencies that we inherit from raft and/or rmm. Depends on rapidsai/raft#345.
Edit 2: I think the CUDA 11.0 thrust issue will be solved by rapidsai/rapids-cmake#98