Changed value of the expensive check param to false in populate_graph_container
#1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expose this in a debug mode API in python in a later commit.
seunghwak
approved these changes
Sep 23, 2021
ChuckHastings
approved these changes
Sep 23, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the value of the expensive check param to false in the call to
populate_graph_container.Since the expensive check is still valuable for test and debugging, the option will be exposed to the python user in a separate PR as part of a debug mode API, and for now it's assumed there's test coverage using the expensive check in the C++ tests.
see also #1840
NOTES:
buglabel since it prevents a bug from surfacing in the C++ expensive check, but it was not the root cause of the recent test failures. Setting expensive check to false needs to happen regardless for performance reasons.