Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed code to disable k_truss on CUDA 11.4 differently #1811

Merged

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Sep 9, 2021

Changed code to disable k_truss on CUDA 11.4 to not use numba.cuda.runtime.get_version() at import time since this creates a CUDA context which breaks dask LocalCUDACluster init (causes a nccl init invaid usage exception).

This code change results in almost the same UX as before, except explicit imports of the k_truss module no longer raise the exception immediately, and instead raise only when a k_truss algo is called.

Tested by ensuring unit tests for the conditional enabling of k_truss still work and also checked that a LocalCUDACluster could properly be created.

Also changed dask_client fixture to module since session was not compatible with tests that tried to create a LocalCUDACluster independently within the same session (rmat tests).

cc @cjnolet @pentschev

…ntime.get_version() at import time since this creates a CUDA context which breaks dask LocalCUDACluster init (causes a nccl init invaid usage exception).
@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Sep 9, 2021
@rlratzel rlratzel requested review from Iroy30 and jnke2016 September 9, 2021 01:58
@rlratzel rlratzel self-assigned this Sep 9, 2021
@rlratzel rlratzel requested a review from a team as a code owner September 9, 2021 01:58
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #1811 (e1222e4) into branch-21.10 (bf64c2c) will increase coverage by 9.85%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #1811      +/-   ##
================================================
+ Coverage         59.85%   69.70%   +9.85%     
================================================
  Files                77      139      +62     
  Lines              3547     8599    +5052     
================================================
+ Hits               2123     5994    +3871     
- Misses             1424     2605    +1181     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/_version.py 44.80% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 90.00% <ø> (ø)
python/cugraph/structure/hypergraph.py
python/cugraph/link_prediction/wjaccard.py
python/cugraph/proto/__init__.py
python/cugraph/community/spectral_clustering.py
...raph/structure/graph_implementation/simpleGraph.py
python/cugraph/layout/__init__.py
... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d798f...e1222e4. Read the comment docs.

@BradReesWork BradReesWork added this to the 21.10 milestone Sep 14, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8444991 into rapidsai:branch-21.10 Sep 14, 2021
@rlratzel rlratzel deleted the branch-21.10-fixktrusscudaguard branch June 17, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants