Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG WCC bug fix #1802

Merged
merged 1 commit into from
Sep 2, 2021
Merged

MG WCC bug fix #1802

merged 1 commit into from
Sep 2, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Sep 2, 2021

create_graph_edgelist (invoked by WCC to create a graph from the edges emitted when concurrently growing BFS trees touch each other) called renumber_edgelist with a valid vertex list argument when invoked by WCC with an invalid vertex list (std::nullopt). This fix checks the validity of the vertex list and calls renumber_edgelist with a valid vertex list only when this function is called with a valid vertex list.

@seunghwak seunghwak requested a review from a team as a code owner September 2, 2021 14:06
@seunghwak seunghwak added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change labels Sep 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1802 (9d25030) into branch-21.10 (bf64c2c) will increase coverage by 12.27%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-21.10    #1802       +/-   ##
=================================================
+ Coverage         59.85%   72.13%   +12.27%     
=================================================
  Files                77      134       +57     
  Lines              3547     8311     +4764     
=================================================
+ Hits               2123     5995     +3872     
- Misses             1424     2316      +892     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/_version.py 44.80% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 90.00% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 89.47% <ø> (ø)
python/cugraph/cugraph/comms/comms.py 34.52% <ø> (ø)
python/cugraph/cugraph/community/__init__.py 70.37% <ø> (ø)
python/cugraph/cugraph/community/ecg.py 100.00% <ø> (ø)
python/cugraph/cugraph/community/egonet.py 92.30% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 84.37% <ø> (ø)
... and 183 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89eb18...9d25030. Read the comment docs.

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a870a09 into rapidsai:branch-21.10 Sep 2, 2021
@seunghwak seunghwak deleted the bug_wcc branch October 19, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants