-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update thrust/RMM deprecated calls #1789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
rerun tests |
If #1707 gets merged, do we need rmm::exec_policy(stream)->on(stream) to rmm::exec_policy(stream) changes in this PR? |
The purpose of this PR is to get merged before #1707, since #1707 is dependent on a series of PRs in other repos getting merged. If somehow #1707 gets merged first then this PR is obsolete and should be closed without merging. |
rerun tests |
It passed CI pointing to a custom branch of raft. There will need to be at least 1 more commit to that branch (after some raft PRs get merged) before it can be merged. |
I see, and thanks for the clarification. I was just worried about a huge number of merge conflicts between this PR and PR 1707, but it seems like it is unavoidable. |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #1789 +/- ##
================================================
- Coverage 59.85% 59.68% -0.17%
================================================
Files 77 77
Lines 3547 3567 +20
================================================
+ Hits 2123 2129 +6
- Misses 1424 1438 +14
Continue to review full report at Codecov.
|
@gpucibot merge |
PR essentially backports the fixes in #1707 for the deprecated RMM exec policy, and unpins the RMM nighlty to unblock local builds and CI and local development. Conflicts with the bigger PR should be minimal, and mainly around a single change:
to