Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily pin RMM while refactor removes deprecated calls #1775

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Aug 14, 2021

This should unblock build locally and in CI. Needs to be undone after #1707 is merged.

cc @ChuckHastings

@dantegd dantegd requested a review from a team as a code owner August 14, 2021 00:17
@dantegd dantegd changed the title Temporarily pin RMM while refactor removed deprecated calls Temporarily pin RMM while refactor removes deprecated calls Aug 14, 2021
@BradReesWork BradReesWork added this to the 21.10 milestone Aug 16, 2021
@BradReesWork BradReesWork added ! - Hotfix non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed ! - Hotfix labels Aug 16, 2021
@BradReesWork
Copy link
Member

rerun tests

@dantegd
Copy link
Member Author

dantegd commented Aug 16, 2021

@BradReesWork just realized that the RAFT PR rapidsai/raft#315 needs to be merged first so that this one passes CI

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor request if possible, which need not hold up approval.

cpp/cmake/thirdparty/get_rmm.cmake Show resolved Hide resolved
@dantegd dantegd requested a review from a team as a code owner August 17, 2021 16:37
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the conda files too, that should cover everything now.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@67d2d98). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #1775   +/-   ##
===============================================
  Coverage                ?   59.63%           
===============================================
  Files                   ?       77           
  Lines                   ?     3535           
  Branches                ?        0           
===============================================
  Hits                    ?     2108           
  Misses                  ?     1427           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d2d98...6627e4d. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7565dc3 into rapidsai:branch-21.10 Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants