Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform reduce v test #1768

Merged
merged 6 commits into from
Aug 11, 2021

Conversation

kaatish
Copy link
Collaborator

@kaatish kaatish commented Aug 10, 2021

Added test for transform_reduce_v primitive.
Fixed comparator in reduce_v test. Added override rmat usecase wherever applicable.

@kaatish kaatish requested review from a team as code owners August 10, 2021 16:23
@kaatish kaatish self-assigned this Aug 10, 2021
@kaatish kaatish added this to the 21.10 milestone Aug 10, 2021
@kaatish kaatish added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 10, 2021
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like in a great shape but I have some minor comments about cosmetics.

cpp/tests/prims/mg_transform_reduce_v.cu Outdated Show resolved Hide resolved
cpp/tests/prims/mg_transform_reduce_v.cu Outdated Show resolved Hide resolved
cpp/tests/prims/mg_transform_reduce_v.cu Show resolved Hide resolved
cpp/tests/prims/mg_transform_reduce_v.cu Outdated Show resolved Hide resolved
cpp/tests/prims/mg_transform_reduce_v.cu Outdated Show resolved Hide resolved
cpp/tests/prims/mg_transform_reduce_v.cu Outdated Show resolved Hide resolved
cpp/tests/prims/mg_transform_reduce_v.cu Show resolved Hide resolved
@ChuckHastings
Copy link
Collaborator

@rerun tests

2 similar comments
@ChuckHastings
Copy link
Collaborator

@rerun tests

@ChuckHastings
Copy link
Collaborator

@rerun tests

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0b3ab53 into rapidsai:branch-21.10 Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants