-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all new graph objects out of experimental namespace #1757
Move all new graph objects out of experimental namespace #1757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but any idea why python tests are failing?
This reverts commit 1087994.
It turns out that the SG python code is still calling the legacy |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #1757 +/- ##
===============================================
Coverage ? 59.75%
===============================================
Files ? 77
Lines ? 3523
Branches ? 0
===============================================
Hits ? 2105
Misses ? 1418
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good, but my eyes got tired after the 40th file or so.
I'm assuming the experimental C++ tests and the EXPERIMENTAL_
prefix given to test binaries will be addressed in the next PR.
@gpucibot merge |
Moved new graph object headers out of experimental directory.
Updated all references to new graph objects to move them into the cugraph namespace.
NOTE: There will be at least one more PR to finish this job (moving a few more files around mostly)