-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete legacy renumbering implementation #1681
Delete legacy renumbering implementation #1681
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #1681 +/- ##
================================================
+ Coverage 59.77% 59.79% +0.02%
================================================
Files 80 80
Lines 3540 3542 +2
================================================
+ Hits 2116 2118 +2
Misses 1424 1424
Continue to review full report at Codecov.
|
Why's this breaking? |
I labeled it breaking because it deletes a function from It was unclear to me which things that break outside users warrant that label. It doesn't break any python users... only if we have users of our legacy C++ API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@gpucibot merge |
This code is no longer used.