Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete legacy renumbering implementation #1681

Merged

Conversation

ChuckHastings
Copy link
Collaborator

This code is no longer used.

@ChuckHastings ChuckHastings requested review from a team as code owners June 21, 2021 17:48
@ChuckHastings ChuckHastings self-assigned this Jun 21, 2021
@ChuckHastings ChuckHastings added breaking Breaking change improvement Improvement / enhancement to an existing function 3 - Ready for Review labels Jun 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2021

Codecov Report

Merging #1681 (91d219b) into branch-21.08 (1030a49) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 91d219b differs from pull request most recent head 3c26395. Consider uploading reports for the commit 3c26395 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #1681      +/-   ##
================================================
+ Coverage         59.77%   59.79%   +0.02%     
================================================
  Files                80       80              
  Lines              3540     3542       +2     
================================================
+ Hits               2116     2118       +2     
  Misses             1424     1424              
Impacted Files Coverage Δ
python/cugraph/linear_assignment/lap.py 71.42% <100.00%> (ø)
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1030a49...3c26395. Read the comment docs.

@seunghwak
Copy link
Contributor

Why's this breaking?

@ChuckHastings
Copy link
Collaborator Author

I labeled it breaking because it deletes a function from functions.hpp. Anyone that wrote code that depended on that function will break.

It was unclear to me which things that break outside users warrant that label. It doesn't break any python users... only if we have users of our legacy C++ API.

@BradReesWork BradReesWork added this to the 21.08 milestone Jun 22, 2021
Copy link
Contributor

@Iroy30 Iroy30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4787a98 into rapidsai:branch-21.08 Jun 24, 2021
@ChuckHastings ChuckHastings deleted the fea_delete_some_obsolete_code branch July 29, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants