Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle int64 in force atlas wrapper and update to uvector #1607

Merged
merged 8 commits into from
May 25, 2021
Merged

Handle int64 in force atlas wrapper and update to uvector #1607

merged 8 commits into from
May 25, 2021

Conversation

hlinsen
Copy link
Contributor

@hlinsen hlinsen commented May 19, 2021

  • Update wrapper to handle int64
  • Use device_uvector

Close: #1581

@hlinsen hlinsen requested review from a team as code owners May 19, 2021 16:11
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@a524206). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 93822cb differs from pull request most recent head b6707cb. Consider uploading reports for the commit b6707cb to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #1607   +/-   ##
===============================================
  Coverage                ?   59.73%           
===============================================
  Files                   ?       79           
  Lines                   ?     3482           
  Branches                ?        0           
===============================================
  Hits                    ?     2080           
  Misses                  ?     1402           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a524206...b6707cb. Read the comment docs.

@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 19, 2021
@BradReesWork BradReesWork added this to the 21.06 milestone May 19, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d1f3fb9 into rapidsai:branch-21.06 May 25, 2021
@trxcllnt
Copy link
Collaborator

I think there's an issue with one of the new device_uvector buffers needing to be initialized, but isn't. I'm seeing all points converge to (0,0) after a few ticks.

@trxcllnt trxcllnt mentioned this pull request May 25, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request May 27, 2021
@trxcllnt
Initialize force_atlas2 old_forces device_uvector, use new `rmm::ex…
595d5b2 
…ec_policy` (#1625)

Fixes an issue where the layout for all points converge to `(0,0)` when running multiple layout ticks after #1607.

* Initializes the `d_old_forces` vector to fix layout issue.
* Updates to `barnes_hut.hpp` to use non-deprecated `rmm::exec_policy`.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Hugo Linsenmaier (https://github.com/hlinsen)
  - Alex Fender (https://github.com/afender)

URL: #1625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@aschaffer aschaffer aschaffer approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@rlratzel rlratzel Awaiting requested review from rlratzel

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
21.06
Development

Successfully merging this pull request may close these issues.

[BUG] forceatlas2 coordinates not consistent in version 0.18 and 0.19+
6 participants
@hlinsen @codecov-commenter @BradReesWork @trxcllnt @aschaffer @ChuckHastings